-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat data to input-week #2230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @maboa. Needs a description and an adjustment to the Firefox notes and data, but it's close. Thank you!
html/elements/input/week.json
Outdated
}, | ||
"firefox": { | ||
"version_added": false, | ||
"notes": "This feature is not implemented yet. See <a href='https://bugzil.la/888320'>bug 888320</a> and <a href='https://wiki.mozilla.org/TPE_DOM/Date_time_input_types'>TPE DOM/Date time input types</a>." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"input": { | ||
"input-week": { | ||
"__compat": { | ||
"mdn_url": "https://developer.mozilla.org/docs/Web/html/Element/input/week", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs "description": "<code>type=\"week\"</code>"
This should be sorted now! Thanks :) |
html/elements/input/week.json
Outdated
}, | ||
"firefox": { | ||
"version_added": false, | ||
"notes": "This feature is not implemented yet. See <a href='https://bugzil.la/888320'>bug 888320</a>." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit, sorry. Can we change this note to only "See <a href='https://bugzil.la/888320'>bug 888320</a>."
Thank you, @maboa!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mark and Daniel! 👍
* master: (175 commits) Add Server-Timing header (mdn#2148) 40th alpha version Add compat data for input-password (mdn#2235) Add addTransceiver() method for RTCPeerConnection. (mdn#2311) Update Payments API for Chrome. (mdn#2378) Add compat data for MutationObserver (mdn#2094) Fix compat data for "let" in Chrome (mdn#1632) Safari has more formdata support now (mdn#2376) Add compat data for Window sub features from A to F (mdn#2109) Add guidelines around worker support and constructors for API subfeatures (mdn#2373) Update place-content.json (mdn#2240) Add compat data for HTMLDetailsElement (mdn#2315) Add compat data for input-month (mdn#2204) Add compat data to input-week (mdn#2230) Add compat data for input-radio (mdn#2208) Add compat data for input-tel (mdn#2226) Add compat data for input-image (mdn#2207) Add compat data for input-number (mdn#2206) Add compat data for input-hidden (mdn#2203) Add compat data for input-file (mdn#2202) ...
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/week